Legacy Code Java

How Much Code To Extract?

There were only three direct calls to RiskAssessor. Why then did you also include the next two lines in getAmountAtRisk()?

That judgment call, friends, is the biggest one to make when applying E&O. The more code you extract and override, the less "of the real thing" you do test.

The code in question


// get risk assessment
String family = riskAssessor.determineFamily(key);
BigDecimal modifier = riskAssessor.determineModifiers(family, key);
BigDecimal baseRisk = riskAssessor.getRisk(family);
BigDecimal finalRisk = baseRisk.multiply(modifier);
BigDecimal amountAtRisk = totalCapital.multiply(finalRisk);

In this case, two elements guided our decision:

Collaboration aside, that paragraphing comment "get risk assessment" is an instance of the Comment code smell. It's telling us what the code does, instead of calling a method named accordingly. That would usually have us extract a method.
After retrieving data from RiskAssessor, the code only produces a simple multiply. We're pretty confident that multiplication works.

(Reading...)

| Tweet...

Page rating:

| Rate this Page

To format...	use this markup:
source code	{source:lang=java\|lineNumbers=false}...{source} (Supported languages: java, cpp, csharp, c, python.)
bold text	__some text__
italicized text	~~some text~~
underlined text	@@some text@@
a method or class name	``myMethod(...)``

All pages


Poor	Needs Work	Acceptable	Cool	Awesome

Type:	Question Comment Error Suppress email notifications?
Subject:
	Formatting Hints
Message:
	Cancel \|

Legacy Code Java

How Much Code To Extract?

Oooops, you can't do that.